-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Testing bibtex key patterns and fixing title_case/capitalize modifiers #2663
[WIP] Testing bibtex key patterns and fixing title_case/capitalize modifiers #2663
Conversation
Just as an idea, maybe you can check if you could include that feature request here? |
@Siedlerchr I've made a first attempt at adding the feature ^_^ |
309048f
to
04cde60
Compare
I have a problem with testing the regexFormatter, it doesn't take protected parts of a sentence into account. I don't really know how I can write the code so that it does take the protected characters into account, since it currently only seems to be done on a letter by letter basis. Any ideas on how this could be done, or shall I just remove the feature here for now? |
Maybe anyone of the other @JabRef/developers has an idea on how to check that |
@tobiasdiez Maybe you have an idea? |
Sorry, I've no deep knowledge about regular expressions in particular and about the formatters in general. |
I understand the question #2663 (comment) as follows: If I replace regex As one cannot change the regex engine, I would
|
Closing this issue due to inactivity 💤 @shitikanth took over at #3096, because it is unlikely, that we get access to https://github.com/delftswa2017/jabref |
Related to koppor#237
I'm working on adding tests for key patterns + key patterns in combination with modifiers.
I found out why the title_case and capitalize modifiers didn't work with shorttitle. It went wrong because before the modifier was applied the shorttitle was already a concatenated string, so the formatter would just see it as a single word.
For example if we have the title "An Awesome Paper on JabRef", it would first turn into "AnAwesomePaper", and then the modifier would turn it into "Anawesomepaper".
gradle localizationUpdate
?